From 7e1f51600c2e6a06d66abdfba3c715e057a851d4 Mon Sep 17 00:00:00 2001 From: Jimi Xenidis Date: Tue, 29 Aug 2006 06:53:58 -0400 Subject: [PATCH] [XEN][POWERPC] cleanup for (;;); When the port first started, we didn't even have panic() working properly so we used "for(;;);" loops to stop execution. Now that output is buffered these look like hangs, since you usually do not see the printk() before. Signed-off-by: Jimi Xenidis Signed-off-by: Hollis Blanchard --- xen/arch/powerpc/dart_u3.c | 8 ++++---- xen/arch/powerpc/external.c | 3 +-- xen/arch/powerpc/papr/tce.c | 6 +++--- 3 files changed, 8 insertions(+), 9 deletions(-) diff --git a/xen/arch/powerpc/dart_u3.c b/xen/arch/powerpc/dart_u3.c index d1b38665b3..3058b57639 100644 --- a/xen/arch/powerpc/dart_u3.c +++ b/xen/arch/powerpc/dart_u3.c @@ -55,10 +55,10 @@ static void u3_inv_all(void) dc.reg.dc_invtlb = 1; out_32(dart_ctl_reg, dc.dc_word); - do { - dc.dc_word = in_32(dart_ctl_reg); - r++; - } while ((dc.reg.dc_invtlb == 1) && (r < (1 << l))); + do { + dc.dc_word = in_32(dart_ctl_reg); + r++; + } while ((dc.reg.dc_invtlb == 1) && (r < (1 << l))); if (r == (1 << l)) { if (l < 4) { diff --git a/xen/arch/powerpc/external.c b/xen/arch/powerpc/external.c index 8d60766b8d..8b9e17a886 100644 --- a/xen/arch/powerpc/external.c +++ b/xen/arch/powerpc/external.c @@ -175,8 +175,7 @@ void init_IRQ(void) void ack_APIC_irq(void) { - printk("%s: EOI the whole MPIC?\n", __func__); - for (;;); + panic("%s: EOI the whole MPIC?\n", __func__); } void ack_bad_irq(unsigned int irq) diff --git a/xen/arch/powerpc/papr/tce.c b/xen/arch/powerpc/papr/tce.c index 2da90ba7c9..69efa6517e 100644 --- a/xen/arch/powerpc/papr/tce.c +++ b/xen/arch/powerpc/papr/tce.c @@ -47,7 +47,7 @@ static void h_put_tce(struct cpu_user_regs *regs) regs->gprs[3] = H_Success; } } - + static void h_get_tce(struct cpu_user_regs *regs) { u32 liobn = regs->gprs[4]; @@ -57,7 +57,7 @@ static void h_get_tce(struct cpu_user_regs *regs) printk("%s: liobn: 0x%x ioba: 0x%lx \n", __func__, liobn, ioba); #endif regs->gprs[3] = H_Function; - for(;;) ; + BUG(); } static void h_stuff_tce(struct cpu_user_regs *regs) @@ -76,7 +76,7 @@ static void h_stuff_tce(struct cpu_user_regs *regs) count); #endif regs->gprs[3] = H_Function; - for(;;); + BUG(); } __init_papr_hcall(H_PUT_TCE, h_put_tce); -- 2.30.2